Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/lsp: fix incorrect line and start of semantic tokens #376

Closed
wants to merge 2 commits into from
Closed

internal/lsp: fix incorrect line and start of semantic tokens #376

wants to merge 2 commits into from

Conversation

hiroebe
Copy link

@hiroebe hiroebe commented Mar 30, 2022

Current implementation returns incorrect result when some of the items are skipped, because positions could be relative to a skipped item. Instead, each position must be relative to the previous item added to the result.

@gopherbot
Copy link
Contributor

This PR (HEAD: c778e32) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/396715 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Peter Weinberger:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hironori Ebe:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Peter Weinberger:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 15b9727) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/396715 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 6eedc7c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/396715 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hironori Ebe:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hironori Ebe:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Peter Weinberger:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/c0f667ec-0e02-4b9d-be89-871d456ac6d9

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 3: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/c0f667ec-0e02-4b9d-be89-871d456ac6d9

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Peter Weinberger:

Patch Set 3: Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Peter Weinberger:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1: Run-TryBot+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Suzy Mueller:

Patch Set 3: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/396715.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 31, 2022
@hiroebe @pjweinbgo
internal/lsp: fix incorrect line and start of semantic tokens
cda13e2 
Current implementation returns incorrect result when some of the items are skipped, because positions could be relative to a skipped item. Instead, each position must be relative to the previous item added to the result.

Change-Id: I3c1a68d37bf0c9cfc1bccfe6f76c25b536224293
GitHub-Last-Rev: 6eedc7c
GitHub-Pull-Request: #376
Reviewed-on: https://go-review.googlesource.com/c/tools/+/396715
Run-TryBot: Peter Weinberger <pjw@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Peter Weinberger <pjw@google.com>
Trust: Peter Weinberger <pjw@google.com>
Trust: Suzy Mueller <suzmue@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/396715 has been merged.

@gopherbot gopherbot closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroebe @gopherbot